Open
Conversation
kratkyzobak
force-pushed
the
credential-provider
branch
4 times, most recently
from
5dad961 to
2fc38e1
Compare
kratkyzobak
force-pushed
the
credential-provider
branch
from
2fc38e1 to
9bf1d51
Compare
dg
force-pushed
the
master
branch
14 times, most recently
from
cdb8832 to
a1798c0
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
1769a67 to
b02f117
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
2d78899 to
2f04c73
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e8459f8 to
23617a8
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
2da238e to
038bab3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
d3018bd to
9dc391a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for dynamic passwords in connection level. Dynamic passwords are supported in various Cloud SQL solutions (Google Cloud SQL, Azure Database For MySQL etc). Usually works as OIDC tokens, which are considered more secure since their short time expiration. "Negative" consequence of short time expiration are lazy instances with statically set password in long running jobs. Password can expire before connection is initialized.
We used "hack" to change password by reflection, but since 3.2.2 is password readonly property, there is no other "simple" solution.
Other solutions mentioned in issue 229 are hard to write in legacy code. This PR uses non-BC way to improve security (by removing static passwords) for legacy codes with simple solution.
PR does not anyhow propose, how should anyone obtain token as it is highly dependent on environment. So password now can be either string (as usuall) or Nette\Database\CredentialProvider interface.